Improve reliability on connection loss #233

aentinger · 2021-03-01T07:51:44Z

This fixes #86 and #221 (:pray:). @jcham @IgorSchelle can you please test?

CC @eclipse1985 @zmoog can please you test on your setup too?

…event getting stuck up in low_read/low_write (BearSSLClient::clientRead/clientWrite.

…ng topic subscription and request of last values. Otherwise it can happen that the connection is ripped out under you and you won't even notice.

eclipse1985 · 2021-03-01T08:27:58Z

Sure, I just uploaded a sketch that uses this PR.

github-actions · 2021-03-01T08:32:09Z

Memory usage change @ 5d3b90c

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m4	🔺 +152 - +224	+0.01 - +0.02	🔺 +8 - +8	0.0 - 0.0
arduino:mbed:envie_m7	🔺 +152 - +216	+0.02 - +0.03	🔺 +8 - +8	0.0 - 0.0
arduino:samd:mkr1000	🔺 +192 - +192	+0.07 - +0.07	🔺 +8 - +8	+0.02 - +0.02
arduino:samd:mkrgsm1400	🔺 +192 - +200	+0.07 - +0.08	🔺 +8 - +8	+0.02 - +0.02
arduino:samd:mkrnb1500	🔺 +192 - +192	+0.07 - +0.07	🔺 +8 - +8	+0.02 - +0.02
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	🔺 0 - +192	0.0 - +0.07	🔺 0 - +8	0.0 - +0.02
arduino:samd:nano_33_iot	🔺 0 - +192	0.0 - +0.07	🔺 0 - +8	0.0 - +0.02
esp32:esp32:esp32	🔺 +132 - +132	+0.01 - +0.01	0 - 0	0.0 - 0.0
esp8266:esp8266:huzzah	🔺 +120 - +120	+0.01 - +0.01	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/ArduinoIoTCloud-Advanced flash	%	examples/ArduinoIoTCloud-Advanced RAM for global variables	%	examples/ArduinoIoTCloud-Basic flash	%	examples/ArduinoIoTCloud-Basic RAM for global variables	%	examples/utility/ArduinoIoTCloud_Travis_CI flash	%	examples/utility/ArduinoIoTCloud_Travis_CI RAM for global variables	%	examples/utility/Provisioning flash	%	examples/utility/Provisioning RAM for global variables	%	examples/utility/SelfProvisioning flash	%	examples/utility/SelfProvisioning RAM for global variables	%
arduino:mbed:envie_m4	216	0.02	8	0.0	224	0.02	8	0.0	152	0.01	8	0.0	216	0.02	8	0.0
arduino:mbed:envie_m7	152	0.02	8	0.0	216	0.03	8	0.0	216	0.03	8	0.0	152	0.02	8	0.0
arduino:samd:mkr1000	192	0.07	8	0.02	192	0.07	8	0.02	192	0.07	8	0.02	192	0.07	8	0.02
arduino:samd:mkrgsm1400	192	0.07	8	0.02	192	0.07	8	0.02	200	0.08	8	0.02	192	0.07	8	0.02
arduino:samd:mkrnb1500	192	0.07	8	0.02	192	0.07	8	0.02	192	0.07	8	0.02	192	0.07	8	0.02
arduino:samd:mkrwan1300	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrwifi1010	192	0.07	8	0.02	192	0.07	8	0.02	192	0.07	8	0.02	192	0.07	8	0.02	0	0.0	0	0.0
arduino:samd:nano_33_iot	192	0.07	8	0.02	192	0.07	8	0.02	192	0.07	8	0.02	192	0.07	8	0.02	0	0.0	0	0.0
esp32:esp32:esp32	132	0.01	0	0.0	132	0.01	0	0.0	132	0.01	0	0.0
esp8266:esp8266:huzzah	120	0.01	0	0.0	120	0.01	0	0.0	120	0.01	0	0.0

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,216,0.02,8,0.0,224,0.02,8,0.0,152,0.01,8,0.0,216,0.02,8,0.0
arduino:mbed:envie_m7,152,0.02,8,0.0,216,0.03,8,0.0,216,0.03,8,0.0,152,0.02,8,0.0
arduino:samd:mkr1000,192,0.07,8,0.02,192,0.07,8,0.02,192,0.07,8,0.02,192,0.07,8,0.02
arduino:samd:mkrgsm1400,192,0.07,8,0.02,192,0.07,8,0.02,200,0.08,8,0.02,192,0.07,8,0.02
arduino:samd:mkrnb1500,192,0.07,8,0.02,192,0.07,8,0.02,192,0.07,8,0.02,192,0.07,8,0.02
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrwifi1010,192,0.07,8,0.02,192,0.07,8,0.02,192,0.07,8,0.02,192,0.07,8,0.02,0,0.0,0,0.0
arduino:samd:nano_33_iot,192,0.07,8,0.02,192,0.07,8,0.02,192,0.07,8,0.02,192,0.07,8,0.02,0,0.0,0,0.0
esp32:esp32:esp32,132,0.01,0,0.0,132,0.01,0,0.0,132,0.01,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,120,0.01,0,0.0,120,0.01,0,0.0,120,0.01,0,0.0,,,,,,,,

IgorSchelle · 2021-03-01T20:21:51Z

Hi, Of course. po 1. 3. 2021 v 8:51 odesílatel Alexander Entinger <[email protected]> napsal:

…

zmoog · 2021-03-01T20:27:52Z

@aentinger deployed on my test weather station.

codecov-io · 2021-03-04T10:02:16Z

Codecov Report

Merging #233 (9852cd6) into master (d8a3a98) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   95.27%   95.15%   -0.12%     
==========================================
  Files          25       24       -1     
  Lines         889      867      -22     
==========================================
- Hits          847      825      -22     
  Misses         42       42

Impacted Files	Coverage Δ
src/property/Property.h	`88.88% <0.00%> (-1.59%)`	⬇️
src/property/PropertyContainer.cpp	`88.88% <0.00%> (-0.40%)`	⬇️
src/property/types/CloudColor.h	`97.05% <0.00%> (-0.03%)`	⬇️
src/property/types/CloudInt.h	`100.00% <0.00%> (ø)`
src/property/types/CloudBool.h	`100.00% <0.00%> (ø)`
src/property/types/CloudFloat.h	`100.00% <0.00%> (ø)`
src/property/types/CloudString.h	`100.00% <0.00%> (ø)`
src/property/types/CloudLocation.h	`100.00% <0.00%> (ø)`
src/property/types/automation/CloudLight.h	`100.00% <0.00%> (ø)`
src/property/types/automation/CloudSwitch.h	`100.00% <0.00%> (ø)`
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68f4b51...9852cd6. Read the comment docs.

github-actions · 2021-03-04T10:32:48Z

Memory usage change @ 9852cd6

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m4	🔺 +152 - +224	+0.01 - +0.02	🔺 +8 - +8	0.0 - 0.0
arduino:mbed:envie_m7	🔺 +152 - +216	+0.02 - +0.03	🔺 +8 - +8	0.0 - 0.0
arduino:samd:mkr1000	🔺 +168 - +176	+0.06 - +0.07	🔺 +8 - +8	+0.02 - +0.02
arduino:samd:mkrgsm1400	🔺 +176 - +176	+0.07 - +0.07	🔺 +8 - +8	+0.02 - +0.02
arduino:samd:mkrnb1500	🔺 +168 - +176	+0.06 - +0.07	🔺 +8 - +8	+0.02 - +0.02
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	🔺 0 - +176	0.0 - +0.07	🔺 0 - +8	0.0 - +0.02
arduino:samd:nano_33_iot	🔺 0 - +176	0.0 - +0.07	🔺 0 - +8	0.0 - +0.02
esp32:esp32:esp32	🔺 +132 - +132	+0.01 - +0.01	0 - 0	0.0 - 0.0
esp8266:esp8266:huzzah	🔺 +120 - +120	+0.01 - +0.01	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/ArduinoIoTCloud-Advanced flash	%	examples/ArduinoIoTCloud-Advanced RAM for global variables	%	examples/ArduinoIoTCloud-Basic flash	%	examples/ArduinoIoTCloud-Basic RAM for global variables	%	examples/utility/ArduinoIoTCloud_Travis_CI flash	%	examples/utility/ArduinoIoTCloud_Travis_CI RAM for global variables	%	examples/utility/Provisioning flash	%	examples/utility/Provisioning RAM for global variables	%	examples/utility/SelfProvisioning flash	%	examples/utility/SelfProvisioning RAM for global variables	%
arduino:mbed:envie_m4	152	0.01	8	0.0	224	0.02	8	0.0	152	0.01	8	0.0	216	0.02	8	0.0
arduino:mbed:envie_m7	152	0.02	8	0.0	216	0.03	8	0.0	216	0.03	8	0.0	152	0.02	8	0.0
arduino:samd:mkr1000	176	0.07	8	0.02	168	0.06	8	0.02	176	0.07	8	0.02	176	0.07	8	0.02
arduino:samd:mkrgsm1400	176	0.07	8	0.02	176	0.07	8	0.02	176	0.07	8	0.02	176	0.07	8	0.02
arduino:samd:mkrnb1500	168	0.06	8	0.02	176	0.07	8	0.02	176	0.07	8	0.02	176	0.07	8	0.02
arduino:samd:mkrwan1300	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrwifi1010	168	0.06	8	0.02	176	0.07	8	0.02	176	0.07	8	0.02	176	0.07	8	0.02	0	0.0	0	0.0
arduino:samd:nano_33_iot	168	0.06	8	0.02	176	0.07	8	0.02	176	0.07	8	0.02	168	0.06	8	0.02	0	0.0	0	0.0
esp32:esp32:esp32	132	0.01	0	0.0	132	0.01	0	0.0	132	0.01	0	0.0
esp8266:esp8266:huzzah	120	0.01	0	0.0	120	0.01	0	0.0	120	0.01	0	0.0

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,152,0.01,8,0.0,224,0.02,8,0.0,152,0.01,8,0.0,216,0.02,8,0.0
arduino:mbed:envie_m7,152,0.02,8,0.0,216,0.03,8,0.0,216,0.03,8,0.0,152,0.02,8,0.0
arduino:samd:mkr1000,176,0.07,8,0.02,168,0.06,8,0.02,176,0.07,8,0.02,176,0.07,8,0.02
arduino:samd:mkrgsm1400,176,0.07,8,0.02,176,0.07,8,0.02,176,0.07,8,0.02,176,0.07,8,0.02
arduino:samd:mkrnb1500,168,0.06,8,0.02,176,0.07,8,0.02,176,0.07,8,0.02,176,0.07,8,0.02
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrwifi1010,168,0.06,8,0.02,176,0.07,8,0.02,176,0.07,8,0.02,176,0.07,8,0.02,0,0.0,0,0.0
arduino:samd:nano_33_iot,168,0.06,8,0.02,176,0.07,8,0.02,176,0.07,8,0.02,168,0.06,8,0.02,0,0.0,0,0.0
esp32:esp32:esp32,132,0.01,0,0.0,132,0.01,0,0.0,132,0.01,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,120,0.01,0,0.0,120,0.01,0,0.0,120,0.01,0,0.0,,,,,,,,

aentinger added 2 commits March 1, 2021 08:41

Through usage of the dedicated flag _sslio_closing we do manage to pr…

0f70b68

…event getting stuck up in low_read/low_write (BearSSLClient::clientRead/clientWrite.

Also check if connection to the MQTT server is still established duri…

5d3b90c

…ng topic subscription and request of last values. Otherwise it can happen that the connection is ripped out under you and you won't even notice.

aentinger added the type: enhancement Proposed improvement label Mar 1, 2021

aentinger self-assigned this Mar 1, 2021

Invalid reinterpret cast causes memory access violation.

d09b90c

aentinger marked this pull request as ready for review March 4, 2021 09:58

Removing no longer needed extern declaration of br_ssl_engine_fail.

9852cd6

arduino-libraries deleted a comment from github-actions bot Mar 4, 2021

aentinger merged commit 70efc00 into master Mar 4, 2021

aentinger deleted the fix-reliability-on-connection-loss branch March 4, 2021 13:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve reliability on connection loss #233

Improve reliability on connection loss #233

Uh oh!

aentinger commented Mar 1, 2021

Uh oh!

eclipse1985 commented Mar 1, 2021

Uh oh!

github-actions bot commented Mar 1, 2021

Uh oh!

IgorSchelle commented Mar 1, 2021 via email

Uh oh!

zmoog commented Mar 1, 2021

Uh oh!

codecov-io commented Mar 4, 2021 •

edited

Loading

Uh oh!

github-actions bot commented Mar 4, 2021

Uh oh!

Uh oh!

Improve reliability on connection loss #233

Improve reliability on connection loss #233

Uh oh!

Conversation

aentinger commented Mar 1, 2021

Uh oh!

eclipse1985 commented Mar 1, 2021

Uh oh!

github-actions bot commented Mar 1, 2021

Uh oh!

IgorSchelle commented Mar 1, 2021 via email

Uh oh!

zmoog commented Mar 1, 2021

Uh oh!

codecov-io commented Mar 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Mar 4, 2021

Uh oh!

Uh oh!

codecov-io commented Mar 4, 2021 •

edited

Loading